Tsconfig zh #1268
Merged
Tsconfig zh #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @Kingwl - if they write a comment saying "LGTM" then it will be merged. |
laosb
approved these changes
Oct 22, 2020
|
Good luck, you can decide yourself when you want to merge 👍🏻 |
crimx
reviewed
Oct 23, 2020
packages/tsconfig-reference/copy/zh/options/allowUmdGlobalAccess.md
Outdated
Show resolved
Hide resolved
crimx
reviewed
Oct 23, 2020
packages/tsconfig-reference/copy/zh/options/allowUmdGlobalAccess.md
Outdated
Show resolved
Hide resolved
crimx
reviewed
Oct 23, 2020
packages/tsconfig-reference/copy/zh/options/allowUmdGlobalAccess.md
Outdated
Show resolved
Hide resolved
|
Is everything ok? |
|
Sounds cool to me - you can tell the bot to merge when you feel good 👍🏻 |
|
There's no new changes(only remove other files). And no more append comment. LGTM. |
|
Merging because @Kingwl is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
They are very confusing options. So I have translated them first.