-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Adds a new library for code samples #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easy link to the rendered README: https://github.com/microsoft/TypeScript-Website/blob/twoslasher/packages/ts-twoslasher/README.md |
Got false positives?Make changes to the global settings spellcheck.json in /artsy/peril-settings. Typos for README.md
Lighthouse Scores
|
Performance | Accessibility | Best Practices | SEO | Progressive Web App |
---|---|---|---|---|
0.97 | 0.9 | 0.93 | 0.7 | 1 |
/tsconfig
Performance | Accessibility | Best Practices | SEO | Progressive Web App |
---|---|---|---|---|
0.93 | 0.9 | 1 | 0.8 | 0.96 |
/docs/handbook/integrating-with-build-tools.html
Performance | Accessibility | Best Practices | SEO | Progressive Web App |
---|---|---|---|---|
0.97 | 0.9 | 1 | 0.77 | 0.96 |
…cting Co-authored-by: Andrew Beresford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step one in the #120 - creates a library which handles the pre-conversion of a code sample into something which will then be embedded inside code samples.
Basically it takes the new-handbook code sample importer, wraps it with tests via fixtures. Then uses those fixtures as documentation in the README so as it gets built out, there'll be more info.