Skip to content

Adds a new library for code samples #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 18, 2019
Merged

Adds a new library for code samples #129

merged 18 commits into from
Nov 18, 2019

Conversation

orta
Copy link
Contributor

@orta orta commented Nov 15, 2019

Step one in the #120 - creates a library which handles the pre-conversion of a code sample into something which will then be embedded inside code samples.

Basically it takes the new-handbook code sample importer, wraps it with tests via fixtures. Then uses those fixtures as documentation in the README so as it gets built out, there'll be more info.

@orta
Copy link
Contributor Author

orta commented Nov 15, 2019

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2019

Messages
📖

Deployed to a PR branch - tsconfig old handbook

Got false positives?

Make changes to the global settings spellcheck.json in /artsy/peril-settings.

Typos for README.md

Line Typo
1 # TypeScript TwoSlasher
4 by the [fourslash test system](https://github.c
13 ndling showing the results of transpilation with certain flags
21 - Think about how to ship to npm
24 The twoslash markup API lives inside your
45 Finally you can set any tsconfig compiler flag using this synt
442 ebug logs by running with the env var of DEBUG="*".
450 is optimized and bundled with Rollup into multiple formats (Common
450 Rollup into multiple formats (CommonJS, UMD, and ES Module).

Lighthouse Scores

/
Performance Accessibility Best Practices SEO Progressive Web App
0.97 0.9 0.93 0.7 1
/tsconfig
Performance Accessibility Best Practices SEO Progressive Web App
0.93 0.9 1 0.8 0.96
/docs/handbook/integrating-with-build-tools.html
Performance Accessibility Best Practices SEO Progressive Web App
0.97 0.9 1 0.77 0.96

Generated by 🚫 dangerJS against 3fa7d26

@orta orta merged commit f6a100e into v2 Nov 18, 2019
@jakebailey jakebailey deleted the twoslasher branch May 17, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant