Skip to content

[PT-BR] Translating Type Checking JavaScript Files #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

luk3skyw4lker
Copy link
Contributor

Starting translation and creating draft PR

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @khaosdoctor and @danilofuchs - if they write a comment saying "LGTM" then it will be merged.

@luk3skyw4lker luk3skyw4lker marked this pull request as ready for review December 22, 2020 20:34
Copy link
Contributor

@khaosdoctor khaosdoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some corrections

luk3skyw4lker and others added 4 commits January 7, 2021 21:51
Co-authored-by: Lucas Santos <[email protected]>
Co-authored-by: Lucas Santos <[email protected]>
Co-authored-by: Lucas Santos <[email protected]>
Co-authored-by: Lucas Santos <[email protected]>
@orta
Copy link
Contributor

orta commented Jan 8, 2021

This PR will need a rebase BTW (I can't push one)

@luk3skyw4lker
Copy link
Contributor Author

luk3skyw4lker commented Jan 8, 2021

This PR will need a rebase BTW (I can't push one)

Could you be more clear about how the rebase should look like? I was fearing that I would have to do one, but I don't really know how or if I should really do it.

Edit: How the commits should look like**

@khaosdoctor
Copy link
Contributor

lgtm

@github-actions github-actions bot merged commit ea33c07 into microsoft:v2 Jan 14, 2021
@github-actions
Copy link
Contributor

Merging because @khaosdoctor is a code-owner of all the changes - thanks!

@khaosdoctor
Copy link
Contributor

well, it went through... That's weird

@orta
Copy link
Contributor

orta commented Jan 15, 2021

Interesting, maybe the API allows for merges even when the UI says it's not feasible - I added code to check that it's mergeable to the bot

@luk3skyw4lker luk3skyw4lker deleted the luk3skyw4lker-ptbr-translation branch January 15, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pt Portuguese language translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants