Skip to content

Translation 3 file to Ko: playground-examples/copy/4-0 #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 2, 2021

Conversation

yahma25
Copy link
Contributor

@yahma25 yahma25 commented Dec 18, 2020

en :

번역 리뷰 요청합니다 : @yeonjuan @guyeol @dvlprsh
ref : #910

리뷰 하실 때, 참고해주시면 감사하겠습니다.

JSDoc Deprecated.ts

  • intellisense, outline은 굳이 한글을 명시하지 않았습니다.
    • intellisense: https://docs.microsoft.com/ko-kr/ 에서도 단어 그대로 번역하는 경우가 더 많았음.
    • outline: 에디터 UI(vscode 기준, 왼쪽 Explorer 패널의 펼치기 메뉴 중 하나)의 이름을 가리키고 있다는 것으로 판단함.

Logical Operators and Assignment.ts

  • 1번 라인에서 Logical Operators와 Assignment가 'and'로 구별되어 있지만, 아래 tc39 proposal에 명시된 것을 기준으로 하여 '논리 할당 연산자'로 번역하였습니다.

감사합니다. :)

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @bumkeyy - if they write a comment saying "LGTM" then it will be merged.

yahma25 and others added 2 commits January 2, 2021 20:24
…al Operators and Assignment.ts


Fix as the suitable expression

Co-authored-by: Kibeom Kwon <[email protected]>
…al Operators and Assignment.ts


Fix as the suitable expression

Co-authored-by: Kibeom Kwon <[email protected]>
@yahma25
Copy link
Contributor Author

yahma25 commented Jan 2, 2021

@bumkeyy 피드백 고맙습니다. 모두 확인하여 반영하였습니다 😄

@bumkeyy
Copy link
Contributor

bumkeyy commented Jan 2, 2021

LGTM

@github-actions github-actions bot merged commit 3e16d7e into microsoft:v2 Jan 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2021

Merging because @bumkeyy is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants