docs: translate Built-in utility types to Japanese #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sasurau4
reviewed
Feb 10, 2020
|
|
||
| // Exclude<Type, RemoveUnion> | ||
|
|
||
| // 型の第一引数に受け取ったユニオン型から、第二引数に受け取ったユニオン型を |
There was a problem hiding this comment.
共用体型は馴染みがなさそう‥と思ったけど、Union Type の説明文はおそらく共用体型になりそうと思ったので共用体型に変えました。:+1:
Quramy
reviewed
Feb 10, 2020
|
|
||
| // Record<KeysFrom, Type> | ||
|
|
||
| // KeysFrom からプロパティの一覧を受け取り、 |
There was a problem hiding this comment.
[nits] KeysFrom から 英単語の日本語の境界に半角スペースが入っています。
基本的には英日単語境界の半角スペースは不要と思うのですが、どうでしょうか？
There was a problem hiding this comment.
個人的にはスペースあったほうが読みやすいと感じます。
ただ、Textlint無い状態で、句読点の後等色んなケースを考えると、スペース無しで統一したほうが良いと思います。:+1:
スペース無しに修正しましたー
Quramy
reviewed
Feb 10, 2020
| // 他の型とは違い、ThisTypeは新しい型を返しません。 | ||
| // 関数で使われる this の型を型引数に受け取った型に変換します。 | ||
| // ThisType は TSConfig の noImplicitThis が true | ||
| // の場合にしか使えません。 |
There was a problem hiding this comment.
[nits] 上記と同じく、半角スペースの件です
// 関数で使われるthisの型を型引数に受け取った型に変換します。
// ThisTypeはTSConfigのnoImplicitThisがtrue
// の場合にしか使えません。
Quramy
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #100 #220
translated Built-in Utility Types in TypeScript playground example.
original document is here.
https://github.com/microsoft/TypeScript-Website/blob/v2/packages/playground-examples/copy/en/TypeScript/Type%20Primitives/Built-in%20Utility%20Types.ts