Skip to content

Add Spanish translations for the playground #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2020
Merged

Add Spanish translations for the playground #237

merged 1 commit into from
Feb 24, 2020

Conversation

carburo
Copy link
Contributor

@carburo carburo commented Feb 11, 2020

This PR is part of #100 #232
These are translations for some of the files in the Playground.
Original files:

@msftclas
Copy link

msftclas commented Feb 11, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

KingDarBoja
KingDarBoja suggested changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comments. I haven't finished yet, so stay sharp for more feedback changes on the rest of files.

packages/playground-examples/copy/es/JavaScript/External APIs/TypeScript with Deno.ts
Comment on lines +3 to +5
// Deno es un entorno en tiempo de ejecución aún
// incompleto para JavaScript y TypeScript basado en
// v8 con un enfoque marcado en la seguridad.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:

Deno es un entorno de ejecución en desarrollo para Javascript y Typescript basado en el motor v8 de Google con un enfoque en la seguridad.

Copy link
Contributor Author

@carburo carburo Feb 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No veo motivo para añadir información adicional a la que está en documento original:
Allí nunca se menciona a Google.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Siempre es bueno clarificar de donde proviene el motor. No creo que exista problema con ello, además que ayuda a los nuevos desarrolladores a indagar en el tema.

Copy link
Contributor Author

@carburo carburo Feb 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De acuerdo en ese aspecto, pero la cuestión es hasta dónde llega el punto del traductor. Mi punto es que no estamos generando contenido original. Creo que en este caso lo mejor es proponer el cambio en la versión en inglés que sirve como referencia y a partir de ahí todas las traducciones se pueden beneficiar.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podemos dejarlo en tu versión por ahora para no retrasar lo demás y preguntar en el discord 👍

KingDarBoja
KingDarBoja reviewed Feb 11, 2020
View reviewed changes
packages/playground-examples/copy/es/JavaScript/Functions with JavaScript/Generic Functions.ts
Comment on lines +3 to +4
// La genericidad proporciona una forma de utilizar tipos
// como variables en otros tipos. Meta.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Los genéricos proporcionan una forma de utilizar tipos como variables en otros tipos.

Also, what is Meta on the original file? Maybe some extra word or was on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sí, está en el original. Se refiere a la primera oración de que la genericidad permite usar tipos como variables en otros tipos (algo así como metatipos). No estoy seguro cuál sería la forma más idiomática de traducirlo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, utiliza Metadatos para traducir ese Meta :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 No creo que metadatos sea exactamente la traducción más feliz. En el texto original parece más bien una forma de guiño o broma al lector.

@KingDarBoja
Copy link
Contributor

@carburo can you merge the latest changes from v2 branch? It should fix the CI errors.

@orta
Copy link
Contributor

orta commented Feb 21, 2020

Cool, - let's get this in? Looks good to me

@KingDarBoja
Copy link
Contributor

@orta branch has been updated with master, it is ready for merge!

@orta
Copy link
Contributor

orta commented Feb 24, 2020

Rock

@orta orta merged commit 902ffa6 into microsoft:v2 Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingDarBoja KingDarBoja KingDarBoja requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carburo @msftclas @KingDarBoja @orta