Skip to content

[WIP] TypeScript Spanish Translation #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 21, 2020
Merged

[WIP] TypeScript Spanish Translation #260

merged 10 commits into from
Feb 21, 2020

Conversation

KingDarBoja
Copy link
Contributor

@KingDarBoja KingDarBoja commented Feb 16, 2020 •
edited
Loading

References #232

app

playground

This is a work-in-progress, do not merge yet.

@KingDarBoja KingDarBoja requested a review from orta February 17, 2020 14:10
walaura
walaura reviewed Feb 17, 2020
View reviewed changes
Copy link

@walaura walaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found some nits on the first two files

@orta
Copy link
Contributor

orta commented Feb 21, 2020

@KingDarBoja are you happy to have this merged?

@KingDarBoja
Copy link
Contributor Author

@KingDarBoja are you happy to have this merged?

Yeah, go ahead :D

@orta orta merged commit 68791d8 into microsoft:v2 Feb 21, 2020
@KingDarBoja KingDarBoja deleted the docs/typescript-spanish-translation branch February 21, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maumercado maumercado maumercado left review comments

@walaura walaura walaura left review comments

@orta orta Awaiting requested review from orta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KingDarBoja @orta @maumercado @walaura