Skip to content

Make the playground run in other pages, and start of a workbench page #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 13, 2020

Conversation

orta
Copy link
Contributor

@orta orta commented Apr 10, 2020

After thinking about it for a bit, getting to something like this:

Re: microsoft/TypeScript#35389

Would either mean:

  • taking the sandbox and wrapping it with a custom sidebar infrastructure
  • taking the playground and allowing for custom sidebar plugins

The choice ended up being pretty easy in the end, so the playground now supports custom sets of plugins - which is how this is implemented

Result of this PR:

2020-04-13 13-37-24 2020-04-13 13_40_49

https://typescript-v2-497.ortam.now.sh/dev/bug-workbench/

@orta
Copy link
Contributor Author

orta commented Apr 10, 2020

and it sets up prettier correctly everywhere too

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2020

Messages
📖

Deployed to a PR branch - playground tsconfig old handbook

Got false positives?

Make changes to the global settings spellcheck.json in /artsy/peril-settings.

Typos for CONTRIBUTING.md

Line Typo
1 ### How to make a change in Twoslash
3 t's likely you have a failing twoslash test case, copy that into `te

Typos for CHANGELOG.md

Line Typo
26 y to set the defaults for the config
30 Initial public version of Twoslash. Good enough for using on the

Typos for README.md

Line Typo
1 # TypeScript TwoSlash
4 by the [fourslash test system](https://github.c
9 You can preview twoslash on the TypeScript website her
11 ### What is Twoslash?
14 twoslash to let the compiler handle er
67 ching this code sample to use twoslash has a few upsides:
70 e sample, if it doesn't occur twoslash throws
73 it more verbose because every twoslash example is a unique compiler
77 The Twoslash markup language helps with:
82 cing code with the results of transpilation to different files, or ancill
82 les, or ancillary files like .d.ts or .map files
90 The twoslash markup API lives inside your
117 Finally you can set any tsconfig compiler flag using this synt
608 ebug logs by running with the env var of DEBUG="*".
616 is optimized and bundled with Rollup into multiple formats (Common
616 Rollup into multiple formats (CommonJS, UMD, and ES Module).

Generated by 🚫 dangerJS against 13a7853

@orta
Copy link
Contributor Author

orta commented Apr 12, 2020

Got all the infra hooked up - looks like a bug with grabbing the queries locations - (I bet its an offset thing, but I'm ok to ship without)

Screen Shot 2020-04-11 at 8 20 14 PM

@orta
Copy link
Contributor Author

orta commented Apr 13, 2020

Cool, this is good enough for a few of my bugs - will expand it out in time

@orta orta merged commit 0e21711 into v2 Apr 13, 2020
@jakebailey jakebailey deleted the wip_workbench branch May 17, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant