-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Handbook -> Docs, i18n doc pages, Double nesting #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Got false positives?Make changes to the global settings spellcheck.json in /artsy/peril-settings. Typos for Basic Types.md
Typos for tsconfig.json.md
Typos for TypeScript Tooling in 5 minutes.md
Typos for React.md
Typos for Migrating from JavaScript.md
Typos for Gulp.md
Typos for DOM Manipulation.md
Typos for Babel with TypeScript.md
Typos for ASP.NET Core.md
Typos for TypeScript 3.9.md
Typos for TypeScript 3.8.md
Typos for TypeScript 3.7.md
Typos for TypeScript 3.6.md
Typos for TypeScript 3.5.md
Typos for TypeScript 3.4.md
Typos for TypeScript 3.3.md
Typos for TypeScript 3.2.md
Typos for TypeScript 3.1.md
Typos for TypeScript 3.0.md
Typos for TypeScript 2.9.md
Typos for TypeScript 2.8.md
Typos for TypeScript 2.7.md
Typos for TypeScript 2.6.md
Typos for TypeScript 2.5.md
Typos for TypeScript 2.4.md
Typos for TypeScript 2.3.md
Typos for TypeScript 2.2.md
Typos for TypeScript 2.1.md
Typos for TypeScript 2.0.md
Typos for TypeScript 1.8.md
Typos for TypeScript 1.7.md
Typos for TypeScript 1.6.md
Typos for TypeScript 1.5.md
Typos for TypeScript 1.4.md
Typos for TypeScript 1.1.md
Typos for Overview.md
Typos for Templates.md
Typos for Publishing.md
Typos for Library Structures.md
Typos for Introduction.md
Typos for Do's and Don'ts.md
Typos for Deep Dive.md
Typos for Creating DTS files From JS.md
Typos for Consumption.md
Typos for By Example.md
Typos for Variable Declarations.md
Typos for Type Inference.md
Typos for Type Compatibility.md
Typos for Type Checking JavaScript Files.md
Typos for Triple-Slash Directives.md
Typos for The Handbook.md
Typos for Symbols.md
Typos for Project References.md
Typos for Nightly Builds.md
Typos for Namespaces.md
Typos for Namespaces and Modules.md
Typos for Modules.md
Typos for Module Resolution.md
Typos for Mixins.md
Typos for Literal Types.md
Typos for JSX.md
Typos for JSDoc Reference.md
Typos for Iterators and Generators.md
Typos for Intro to JS with TS.md
Typos for Interfaces.md
Typos for Integrating with Build Tools.md
Typos for TS for the New Programmer.md
Typos for TS for OOPers.md
Typos for TS for JS Programmers.md
Typos for TS for Functional Programmers.md
Typos for Generics.md
Typos for Functions.md
Typos for Enums.md
Typos for Decorators.md
Typos for Declaration Merging.md
Typos for Configuring Watch.md
Typos for Compiler Options.md
Typos for Compiler Options in MSBuild.md
Typos for Classes.md
Typos for Basic Types.md
Typos for Advanced Types.md
Typos for README.md
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i8n Doc Page
Succinct Nav
The nav is now basically impossible to get wrong, filepaths are typed:
Release notes are automatically added on deploys.
Double Nesting
Docs navigation now supports nesting 2 levels. Today this is only needed for the .d.ts templates but I have plans which need this also.
TODO: