Skip to content

Translate handbook #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2020
Merged

Translate handbook #819

merged 1 commit into from
Jul 30, 2020

Conversation

kimuradev
Copy link

@kimuradev kimuradev commented Jul 30, 2020 •
edited
Loading

My first humble contribution :)

@khaosdoctor , @danilofuchs, @orta

danilofuchs
danilofuchs approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@danilofuchs danilofuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danilofuchs danilofuchs mentioned this pull request Jul 30, 2020
Closed
@khaosdoctor
Copy link
Contributor

LGTM @orta

@danilofuchs
Copy link
Contributor

I just found out that these files must be imported in a new packages/typescriptlang-org/src/copy/pt.ts file. I created it on #822

@orta
Copy link
Contributor

orta commented Jul 30, 2020

👍 yeah, these ones don't automagically appear unlike the rest (they also live in browser land so I can't use the fs to look them up)

@orta
Copy link
Contributor

orta commented Jul 30, 2020

Let's not have it be blocked on that, it's easy to add in the future, great work - thanks for the contribution!

@orta orta merged commit 46c29a1 into microsoft:v2 Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaosdoctor khaosdoctor khaosdoctor approved these changes

@danilofuchs danilofuchs danilofuchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kimuradev @khaosdoctor @danilofuchs @orta