Skip to content

[pt-br] Translation files from tsconfig-reference #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 19, 2020

Conversation

cataua
Copy link
Contributor

@cataua cataua commented Aug 8, 2020

My first contribution, I hope it's helpful and I made all proceed correctly. @khaosdoctor, @alvarocamillont, @danilofuchs e @orta

The files are:
Command_line_Options_6171.md
Experimental_Options_6177.md
Module_Resolution_Options_6174.md
Project_Files_0.md
Source_Map_Options_6175.md
Strict_Type_Checking_Options_6173.md
Watch_Options_999.md

@ghost
Copy link

ghost commented Aug 8, 2020

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@khaosdoctor khaosdoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes on files

Copy link
Contributor

@khaosdoctor khaosdoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@khaosdoctor
Copy link
Contributor

@orta can you resolve this conflict? I don't have permissions

@orta orta self-requested a review as a code owner August 17, 2020 12:04
cataua and others added 4 commits August 18, 2020 18:46
…cking_Options_6173.md

Co-authored-by: Danilo Campana Fuchs <[email protected]>
…cking_Options_6173.md

Co-authored-by: Danilo Campana Fuchs <[email protected]>
…cking_Options_6173.md

Co-authored-by: Danilo Campana Fuchs <[email protected]>
…cking_Options_6173.md

Co-authored-by: Danilo Campana Fuchs <[email protected]>
Copy link
Contributor

@danilofuchs danilofuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orta
Copy link
Contributor

orta commented Aug 19, 2020

Ah, close

Looking at the pull_request_review from danilofuchs in '[pt-br] Translation files from tsconfig-reference' to see if we can merge

Changed files: 
 - /packages/tsconfig-reference/copy/pt/categories/Command_line_Options_6171.md
 - /packages/tsconfig-reference/copy/pt/categories/Experimental_Options_6177.md
 - /packages/tsconfig-reference/copy/pt/categories/Module_Resolution_Options_6174.md
 - /packages/tsconfig-reference/copy/pt/categories/Project_Files_0.md
 - /packages/tsconfig-reference/copy/pt/categories/Source_Map_Options_6175.md
 - /packages/tsconfig-reference/copy/pt/categories/Strict_Type_Checking_Options_6173.md
 - /packages/tsconfig-reference/copy/pt/categories/Watch_Options_999.md
 - /packages/typescriptlang-org/src/lib/release-info.json

@danilofuchs does not have access to merge 
 - /packages/typescriptlang-org/src/lib/release-info.json

@orta orta merged commit 279b51d into microsoft:v2 Aug 19, 2020
@danilofuchs
Copy link
Contributor

I cannot merge since there are changes in release-info.json. I've seen this file being updated quite frequently in translation PRs. Is this expected, @orta?

@orta
Copy link
Contributor

orta commented Aug 19, 2020

Yeah, maybe I should just gitignore it at this point

@danilofuchs
Copy link
Contributor

Ah, close

Hahaha so close, indeed. Next time it's going to work flawlessly, I'm sure!

@khaosdoctor
Copy link
Contributor

@cataua Please update the spreadsheet on #233 so we know you finished :)

@cataua
Copy link
Contributor Author

cataua commented Aug 20, 2020

@cataua Please update the spreadsheet on #233 so we know you finished :)

Done, @khaosdoctor !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants