-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Translate tsconfig-reference files to ko #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR! This section of the codebase is owned by @bumkeyy - if they write a comment saying "LGTM" then it will be merged. |
Hi - thanks! So, I'd like to have someone else review this PR to make sure that the Korean makes sense. I only speak English (and Portuguese badly) so: @dvlprsh @yeonjuan @guyeol - you are top contributors to the Korean translation repo Could I maybe ask you to review this PR for how it sounds in Korean? If you'd like to get involved more, we have a Korean translation channel in the TypeScript Community Discord. Come say hi! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bumkeyy 일부 표현이 부자연스러운 것 같아 suggestion 남겼습니다 :)
Co-authored-by: YeonJuan <[email protected]>
Co-authored-by: YeonJuan <[email protected]>
Co-authored-by: YeonJuan <[email protected]>
@yeonjuan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Co-authored-by: Seohee Park <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
Thanks folks! |
This is live on staging: https://www.staging-typescript.org/ko/tsconfig |
Hi :)
It's first commit to translate typescript file to Korean!
This current PR translate the following files:
Ref : #910