Skip to content

Translate tsconfig-reference files to ko #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 19, 2020
Merged

Translate tsconfig-reference files to ko #931

merged 7 commits into from
Aug 19, 2020

Conversation

bumkeyy
Copy link
Contributor

@bumkeyy bumkeyy commented Aug 18, 2020

Hi :)
It's first commit to translate typescript file to Korean!

This current PR translate the following files:

Ref : #910

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @bumkeyy - if they write a comment saying "LGTM" then it will be merged.

@orta
Copy link
Contributor

orta commented Aug 18, 2020

Hi - thanks!

So, I'd like to have someone else review this PR to make sure that the Korean makes sense. I only speak English (and Portuguese badly) so: @dvlprsh @yeonjuan @guyeol - you are top contributors to the Korean translation repo

Could I maybe ask you to review this PR for how it sounds in Korean?

If you'd like to get involved more, we have a Korean translation channel in the TypeScript Community Discord. Come say hi!

@ghost
Copy link

ghost commented Aug 18, 2020

CLA assistant check
All CLA requirements met.

@bumkeyy bumkeyy changed the title [PR-KO] Translating tsconfig-reference intro.md file [PR-KO] Translating tsconfig-reference files Aug 18, 2020
@bumkeyy bumkeyy changed the title [PR-KO] Translating tsconfig-reference files Translating tsconfig-reference files to ko Aug 18, 2020
@bumkeyy bumkeyy changed the title Translating tsconfig-reference files to ko Translate tsconfig-reference files to ko Aug 18, 2020
@bumkeyy bumkeyy requested a review from orta as a code owner August 19, 2020 09:31
Copy link
Contributor

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bumkeyy 일부 표현이 부자연스러운 것 같아 suggestion 남겼습니다 :)

@bumkeyy
Copy link
Contributor Author

bumkeyy commented Aug 19, 2020

@yeonjuan
Thanks 👍

Copy link
Contributor

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Copy link
Contributor

@dvlprsh dvlprsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@orta
Copy link
Contributor

orta commented Aug 19, 2020

Thanks folks!

@orta orta merged commit bc42615 into microsoft:v2 Aug 19, 2020
@orta
Copy link
Contributor

orta commented Aug 19, 2020

This is live on staging: https://www.staging-typescript.org/ko/tsconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants