Skip to content

High cpu usage on 01/29 insiders build #21459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjbvz opened this issue Jan 29, 2018 · 1 comment
Closed

High cpu usage on 01/29 insiders build #21459

mjbvz opened this issue Jan 29, 2018 · 1 comment
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue High Priority

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jan 29, 2018

tsserver.log.zip

TypeScript Version: 2.7.1-insiders-2018.0129

@Tyriar reports high CPU usage when working in the VS Code workspace with the latest insiders. I have attached the logs

tsserver.log.zip

@sheetalkamat Seems like we are scanning node_modules here. Not sure if that is expected. Tail of the logs have a bunch of message of the form:

...
Info 29856[12:4:46.663] DirectoryWatcher recursive:: Elapsed: 30ms Trigger: /Users/daimms/dev/Microsoft/vscode/node_modules/bufferstreams/src/index.js PathInfo: /Users/daimms/dev/Microsoft/vscode/node_modules Project: /Users/daimms/dev/Microsoft/vscode/src/tsconfig.json WatchType: Directory of Failed lookup locations in module resolution
Info 29856[12:4:46.663] DirectoryWatcher recursive:: Trigger: /Users/daimms/dev/Microsoft/vscode/node_modules/bufferstreams/src PathInfo: /Users/daimms/dev/Microsoft/vscode/node_modules Project: /Users/daimms/dev/Microsoft/vscode/src/tsconfig.json WatchType: Directory of Failed lookup locations in module resolution
Info 29856[12:4:46.664] DirectoryWatcher recursive:: Elapsed: 1ms Trigger: /Users/daimms/dev/Microsoft/vscode/node_modules/bufferstreams/src PathInfo: /Users/daimms/dev/Microsoft/vscode/node_modules Project: /Users/daimms/dev/Microsoft/vscode/src/tsconfig.json WatchType: Directory of Failed lookup locations in module resolution
Info 29856[12:4:46.664] DirectoryWatcher recursive:: Trigger: /Users/daimms/dev/Microsoft/vscode/node_modules/bufferstreams PathInfo: /Users/daimms/dev/Microsoft/vscode/node_modules Project: /Users/daimms/dev/Microsoft/vscode/src/tsconfig.json WatchType: Directory of Failed lookup locations in module resolution
Info 29856[12:4:46.664] Scheduled: /Users/daimms/dev/Microsoft/vscode/src/tsconfig.json, Cancelled earlier one
Info 29856[12:4:46.664] Scheduled: *refreshInferredProjects*, Cancelled earlier one
...
@mjbvz mjbvz added the VS Code Tracked There is a VS Code equivalent to this issue label Jan 29, 2018
@mhegazy mhegazy added this to the TypeScript 2.7.1 milestone Jan 29, 2018
@mhegazy mhegazy added Bug A bug in TypeScript High Priority and removed VS Code Tracked There is a VS Code equivalent to this issue labels Jan 29, 2018
@sheetalkamat
Copy link
Member

I am not sure why the directory watcher is invoked on the already present source files. We expect that to be file watcher instead. But even apart from that, i think we are spending too much time in isEmittedFile

@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jan 30, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue High Priority
Projects
None yet
Development

No branches or pull requests

3 participants