Skip to content

Improve error message for missing resolveJsonModule #25722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Jul 17, 2018 · 0 comments
Closed

Improve error message for missing resolveJsonModule #25722

ghost opened this issue Jul 17, 2018 · 0 comments
Assignees
@sheetalkamat
Labels
Domain: Error Messages The issue relates to error messaging Fixed A PR has been merged for this issue Suggestion An idea for TypeScript
Milestone
TypeScript 3.1

Comments

@ghost
Copy link

ghost commented Jul 17, 2018

TypeScript Version: 3.1.0-dev.20180717

Code

import foo = require("./foo.json");

Expected behavior:

Error mentioning that resolveJsonModule is not set.

Actual behavior:

Unhelpful error: Cannot find module './foo.json'. (But it's right there!)
@ghost ghost added Suggestion An idea for TypeScript Domain: Error Messages The issue relates to error messaging labels Jul 17, 2018
@mhegazy mhegazy added this to the TypeScript 3.1 milestone Jul 17, 2018
sheetalkamat added a commit that referenced this issue Jul 25, 2018
@sheetalkamat
When json module is not found, include enabling --resolveJsonModule m…
dfb5cbd 
…ight help.

Fixes #25722
@sheetalkamat sheetalkamat mentioned this issue Jul 25, 2018
Merged
@sheetalkamat sheetalkamat added the Fixed A PR has been merged for this issue label Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sheetalkamat sheetalkamat

Labels
Domain: Error Messages The issue relates to error messaging Fixed A PR has been merged for this issue Suggestion An idea for TypeScript
Projects
None yet
Milestone
TypeScript 3.1
Development

No branches or pull requests
2 participants
@mhegazy @sheetalkamat