Skip to content

Extract type refactoring duplicates nearby comments #31629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tyriar opened this issue May 28, 2019 · 1 comment · Fixed by #40245
Closed

Extract type refactoring duplicates nearby comments #31629

Tyriar opened this issue May 28, 2019 · 1 comment · Fixed by #40245
Assignees
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue Rescheduled This issue was previously scheduled to an earlier milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented May 28, 2019

microsoft/vscode#74310

image

image

@mjbvz mjbvz transferred this issue from microsoft/vscode May 28, 2019
@mjbvz
Copy link
Contributor

mjbvz commented May 28, 2019

Tested with [email protected]

Example code:

type a = { x: string } /* foo */ | string /* bar */;

Select the entire type and run extract type. Result:

type NewType = {
    x: string;
} /* foo */ | string /* bar */;

type a = NewType /* bar */;

@mjbvz mjbvz removed their assignment May 28, 2019
@mjbvz mjbvz changed the title TypeScript extract type duplicates nearby comments Extract type refactoring duplicates nearby comments May 28, 2019
@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Jun 13, 2019
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.6.0 milestone Jun 13, 2019
@orta orta added the Fix Available A PR has been opened for this issue label Jul 16, 2019
orta added a commit to orta/TypeScript that referenced this issue Apr 22, 2020
@orta orta added the Rescheduled This issue was previously scheduled to an earlier milestone label May 12, 2020
@orta orta removed this from the TypeScript 3.9.1 milestone May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue Rescheduled This issue was previously scheduled to an earlier milestone
Projects
None yet
5 participants