Skip to content

Investigate undocumented readDirectory change #45990

Closed
@DanielRosenwasser

Description

@DanielRosenwasser

@amcasey Hi! I don't know if it the right place to ask a question but I found this thread relative to the problem (I'm sorry if it's not). Should directoryExists be called with an absolute path like directoryExists(combinePaths(currentDirectory, basePath))?

I came across the undocumented breaking change in 4.4-beta that causes (for example) ts.sys.readDirectory("", [".ts",".tsx",".d.ts"],["node_modules","dist"],["**/*"]) to return an empty array. Before 4.4-beta it has been returning the correct array of files. So I wonder if it is a bug or desired behaviour.

Thank you in advance.

Originally posted by @gretzkiy in #44710 (comment)

Metadata

Metadata

Assignees

Labels

BugA bug in TypeScriptFix AvailableA PR has been opened for this issue

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions