source.organizeImports causing extra blank line

[clabough]

TS Template added by @mjbvz

TypeScript Version: 4.6.2

Search Terms

• organize imports
• source action

---

Issue Type: Bug

source.organizeImports is adding an extra blank line at the end when the typescript file only has exports. If there are any other lines (e.g. code) after the exports, then the extra line does not get added.

VS Code version: Code 1.65.0 (b5205cc8eb4fbaa726835538cd82372cc0222d43, 2022-03-02T11:12:08.962Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

Extensions: none

In this project, I've created a new default Angular project and added an index.ts to show the issue.

[mjbvz]

Minimal repo file:

import 'fs';

This returns the following code edit:

[Trace  - 23:49:58.180] <semantic> Response received: organizeImports (276). Request took 2 ms. Success: true 
Result: [
    {
        "fileName": "/Users/matb/projects/san/index.tsx",
        "textChanges": [
            {
                "start": {
                    "line": 1,
                    "offset": 1
                },
                "end": {
                    "line": 1,
                    "offset": 13
                },
                "newText": "import 'fs';\n"
            }
        ]
    }
]

[RyanCavanaugh]

It seems to top out at 2 trailing newlines, so the process at least reaches a fixed point. This doesn't seem like a priority.

[clabough]

@RyanCavanaugh If you're using the linting rule 'no-multiple-empty-lines', then saving causes a violation of that rule, and without knowing about the 'File:Save without formatting', you end up in an endless loop.