import statements are transpiled even if output is set to ES6

[tomitrescak]

Hi

Up until latest update my es6 imports were left the way they was when transpilig to es6.
From the latest update now they are transpiled to the module representation.

For example:

import TabControl from "../../components/tabs/tab_control";

is transpiled to

var tab_control_1 = require("../../components/tabs/tab_control");

The worst part is, that it breaks the TSX transpilation as for example

  <TabControl tabs={this.state.tabs}>
            {
              this.props.validations.map((validation: BoardValidation, index: number) => {
                return <BoardValidationView key={index} />
              })
            }
</TabControl>

is transpiled to:

<tab_control_1.default tabs={this.state.tabs}>
            {this.props.validations.map((validation, index) => {
            return <BoardValidationView key={index} />;
        })}
          </TabControl>

Note how the closing tag is not transpiled.

This is probably bug in transpilation, but can the transpilation of import statements be disabled? Up until today all was working well ... now none of my TS project runs ;((

For completeness, here is my tsconfig

{
    "compilerOptions": {
        "target": "es6",
        "declaration": false,
        "noImplicitAny": true,
        "removeComments": false,
        "noLib": false,
        "preserveConstEnums": true,
        "noEmitHelpers": true,
        "suppressImplicitAnyIndexErrors": true,
        "watch": true,
        "outDir": "../dist",
        "jsx": "preserve"
    },
...
}

[sandersn]

What version did the latest update give you? I tried the following code with 1.6.2:

import TabControl from "tab_control";
let t = new TabControl();

With a file named tab_control.ts:

class TabControl {
    // nothing here
}
export default TabControl;

And using your tsconfig, I got the below output:

import TabControl from "tab_control";
let t = new TabControl();

[basarat]

What version did the latest update give you?

The version from master two days ago.

Tracked from atom-typescript package.json to this version

The bug was not in this version : git tag and not in 1.6 either (which is even older).

[mhegazy]

@basarat do you have a reproduction of this issue that you can share?

[basarat]

Original issue report TypeStrong/atom-typescript#643 But I'll test more ... see below:

do you have a reproduction of this issue that you can share?

Quick test with [email protected] yielded valid results :

I'll investigate further the next time I upgrade and comment. Sorry about a possibly invalid issue 🌹

[basarat]

@tomitrescak can you share a sample ... Would save me some time as another user had the same issue 🌹

[tomitrescak]

Dears, unfortunatelly it only happened in that given version of Atom Typescript.
I tried to replicate in console but no luck. Am glad that someone else experience the same issue so that I'm not crazey ... ;)

[DeusProx]

Hello I got the same problem.
I'm using tsc 1.6.2 in terminal which is compiling fine but using atom-typescript 7.6.3 with the following tscconfig doesn't compile correctly to es6 (require instead of import):

{
    "version": "1.6.2",
    "compileOnSave": true,
    "compilerOptions": {
        "target": "es6",
        "declaration": false,
        "noImplicitAny": false,
        "removeComments": true,
        "emitDecoratorMetadata": true,
        "experimentalDecorators": true,
        "noLib": false,
        "outDir": "build"
    },
    "filesGlob": [       ...many.....    ],
    "files": [  ....many.....   ],
    "exclude": []
}

Previously it worked with an older version of atom-typescript on my laptop. On my pc i'm still using 7.4.3 and everything works fine.

I also tried ntypescript(1.8.0) and it also transpiled correctly.

[basarat]

Note: @Chocoloper tried with the command line (same version of ntypescript) and it works fine :-/

@Chocoloper can you share some simple files for my testing

[DeusProx]

I made a small example. Take a look at the readme too see which versions I used and what the output was:
http://plnkr.co/edit/3ASb6cjkKf2CUJwhpp3p

[basarat]

@Chocoloper Cheers. I have a repro

I suspect its because of a recent change where ES6 module compilation and ES6 general compilation were split (I think I saw an issue or PR regarding this but search is failing me).

In any case the sample project : https://github.com/TypeStrong/atom-typescript-examples/tree/master/bugs/643 if save in atom-ts a.js comes out with require instead of import from (since target is es6)

[basarat]

I've double checked that we are passing the right options to the language service:

2 is ES6:

    enum ScriptTarget {
        ES3 = 0,
        ES5 = 1,
        ES6 = 2,
        ES2015 = 2,
        Latest = 2,
    }

[weswigham]

I see module is set to 1, though - and that would be commonjs.

[basarat]

I suspect its because of a recent change where ES6 module compilation and ES6 general compilation were split (I think I saw an issue or PR regarding this but search is failing me).

Found it : #4811

I see module is set to 1, though - and that would be commonjs.

@weswigham thanks for spotting that 🌹 I'll fix it.

@Chocoloper Use "module": "es6", as a quick workaround : https://github.com/TypeStrong/atom-typescript/releases/tag/v7.7.0

{
    "transpiler": "typescript",
    "compileOnSave": true,
    "compilerOptions": {
        "target": "es6",
        "module": "es6",
        "declaration": false,
        "noImplicitAny": false,
        "removeComments": true,
        "emitDecoratorMetadata": true,
        "experimentalDecorators": true,
        "noLib": false,
        "outDir": "build"
    }
}

[basarat]

From @tomitrescak's original comment

The worst part is, that it breaks the TSX transpilation as for example

would still be a bug if one does want to target ES6 but transpile modules to commonjs (perhaps others also) 🌹

[weswigham]

I think that bug is specific to the JSXClosingTag, by the looks of it. The rest of the example is correct for commonjs emit. Possibly a kind of regression of what #4096 fixed?

[mhegazy]

@basarat is this still an issue?

[basarat]

@mhegazy nope, thanks! 🌹

[mhegazy]

thanks!