Skip to content

[NewErrors] 5.7.0-dev.20240929 vs 5.6.2 #60095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
typescript-bot opened this issue Sep 29, 2024 · 88 comments · Fixed by #60122
Closed

[NewErrors] 5.7.0-dev.20240929 vs 5.6.2 #60095

typescript-bot opened this issue Sep 29, 2024 · 88 comments · Fixed by #60122
Assignees
Labels
Needs Investigation This issue needs a team member to investigate its status.

Comments

@typescript-bot
Copy link
Collaborator

The following errors were reported by 5.7.0-dev.20240929, but not by 5.6.2
Pipeline that generated this bug
Logs for the pipeline run
File that generated the pipeline

This run considered 800 popular TS repos from GH (after skipping the top 0).

Successfully analyzed 453 of 800 visited repos
Outcome Count
Detected interesting changes 78
Detected no interesting changes 375
Git clone failed 7
Package install failed 102
Project-graph error in old TS 10
Too many errors in old TS 208
Unknown failure 20

Investigation Status

Repo Errors Outcome
a16z-infra/ai-town 3
a16z-infra/companion-app 1
adobe/react-spectrum 5
alan2207/bulletproof-react 2
alangpierce/sucrase 1
antfu-collective/ni 1
apache/superset 1
AykutSarac/jsoncrack.com 1
bitwarden/clients 46
Blazity/next-enterprise 1
captbaritone/webamp 1
compiler-explorer/compiler-explorer 4
CopilotKit/CopilotKit 2
dinerojs/dinero.js 1
documenso/documenso 1
Dokploy/dokploy 3
dotansimha/graphql-code-generator 1
dotansimha/graphql-yoga 1
facebook/docusaurus 1
feathersjs/feathers 2
getsentry/sentry-javascript 1
getumbrel/llama-gpt 1
graphql-kit/graphql-voyager 2
heyxyz/hey 3
i18next/next-i18next 2
ikatyang/emoji-cheat-sheet 2
immich-app/immich 1
immutable-js/immutable-js 1
ionic-team/stencil 4
ItzCrazyKns/Perplexica 1
ixartz/Next-js-Boilerplate 1
jackyzha0/quartz 3
joe-bell/cva 1
kysely-org/kysely 1
labring/FastGPT 1
leptonai/search_with_lepton 1
majodev/google-webfonts-helper 1
mapbox/mapbox-gl-js 1
marp-team/marp 1
mayooear/gpt4-pdf-chatbot-langchain 1
metricsgraphics/metrics-graphics 1
microsoft/azuredatastudio 10
misskey-dev/misskey 12
netless-io/flat 2
ngrx/platform 1
nodejs/nodejs.org 1
noodle-run/noodle 1
Nutlope/aicommits 2
Nutlope/roomGPT 1
pixijs/pixijs 5
pubkey/rxdb 3
react-cosmos/react-cosmos 1
react-hook-form/react-hook-form 2
recharts/recharts 12
reduxjs/redux-toolkit 1
reduxjs/reselect 1
refined-github/refined-github 1
resend/react-email 1
runtipi/runtipi 6
SawyerHood/draw-a-ui 1
scalar/scalar 1
shadcn-ui/ui 1
slab/quill 4
spacedriveapp/spacedrive 1
streetwriters/notesnook 2
t3-oss/create-t3-app 1
th-ch/youtube-music 1
trpc/trpc 1
twentyhq/twenty 1
ueberdosis/tiptap 8
Uniswap/web3-react 1
upscayl/upscayl 1
urql-graphql/urql 19
vercel/commerce 1
vercel/nextjs-subscription-payments 1
vercel/platforms 1
wandb/openui 1
windingwind/zotero-pdf-translate 4
@typescript-bot
Copy link
Collaborator Author

a16z-infra/ai-town

tsconfig.json

@typescript-bot
Copy link
Collaborator Author

a16z-infra/companion-app

tsconfig.json

@typescript-bot
Copy link
Collaborator Author

adobe/react-spectrum

9 of 15 projects failed to build with the old tsc and were ignored

starters/tailwind/tsconfig.json

  • error TS2322: Type '{ children: (Element | ReactNode | ((values: CheckboxRenderProps & { defaultChildren: ReactNode; }) => ReactNode))[]; }' is not assignable to type '{ children?: ReactNode; }'.
  • error TS2322: Type '{ children: (Element | ReactNode | ((values: GridListItemRenderProps & { defaultChildren: ReactNode; }) => ReactNode))[]; }' is not assignable to type '{ children?: ReactNode; }'.
  • error TS2322: Type '{ children: (Element | ReactNode | ((values: RadioRenderProps & { defaultChildren: ReactNode; }) => ReactNode))[]; }' is not assignable to type '{ children?: ReactNode; }'.
  • error TS2322: Type '{ children: (Element | ReactNode | ((values: TagRenderProps & { defaultChildren: ReactNode; }) => ReactNode))[]; }' is not assignable to type '{ children?: ReactNode; }'.

examples/rsp-next-ts/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

alan2207/bulletproof-react

apps/nextjs-pages/tsconfig.json

apps/nextjs-app/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

alangpierce/sucrase

6 of 18 projects failed to build with the old tsc and were ignored

integration-test/test-cases/ts-node-cases/jsx-cases/jsx-factory-config-is-respected/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

antfu-collective/ni

tsconfig.json

  • error TS2345: Argument of type 'string | Buffer' is not assignable to parameter of type 'string | ArrayBufferView | Iterable<string | ArrayBufferView> | AsyncIterable<string | ArrayBufferView> | Stream'.

@typescript-bot
Copy link
Collaborator Author

apache/superset

31 of 34 projects failed to build with the old tsc and were ignored

docs/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

AykutSarac/jsoncrack.com

tsconfig.json

@typescript-bot
Copy link
Collaborator Author

bitwarden/clients

25 of 59 projects failed to build with the old tsc and were ignored

libs/vault/tsconfig.spec.json

libs/vault/tsconfig.json

libs/tools/send/send-ui/tsconfig.spec.json

libs/tools/send/send-ui/tsconfig.json

libs/tools/generator/extensions/navigation/tsconfig.spec.json

libs/tools/generator/extensions/navigation/tsconfig.json

libs/tools/generator/extensions/legacy/tsconfig.spec.json

libs/tools/generator/extensions/legacy/tsconfig.json

libs/tools/generator/extensions/history/tsconfig.spec.json

libs/tools/generator/extensions/history/tsconfig.json

libs/tools/generator/core/tsconfig.spec.json

libs/tools/generator/core/tsconfig.json

libs/tools/export/vault-export/vault-export-ui/tsconfig.spec.json

libs/tools/export/vault-export/vault-export-ui/tsconfig.json

libs/importer/tsconfig.spec.json

libs/importer/tsconfig.json

libs/auth/tsconfig.spec.json

libs/auth/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

Blazity/next-enterprise

tsconfig.json

  • error TS2686: 'React' refers to a UMD global, but the current file is a module. Consider adding an import instead.

@typescript-bot
Copy link
Collaborator Author

compiler-explorer/compiler-explorer

3 of 6 projects failed to build with the old tsc and were ignored

tsconfig.tests.json

tsconfig.json

@typescript-bot
Copy link
Collaborator Author

CopilotKit/CopilotKit

9 of 17 projects failed to build with the old tsc and were ignored

examples/coagents-ai-researcher/ui/tsconfig.json

docs/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

dinerojs/dinero.js

1 of 4 projects failed to build with the old tsc and were ignored

website/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

documenso/documenso

13 of 17 projects failed to build with the old tsc and were ignored

apps/documentation/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

Dokploy/dokploy

apps/website/tsconfig.json

apps/dokploy/tsconfig.json

apps/docs/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

dotansimha/graphql-code-generator

7 of 23 projects failed to build with the old tsc and were ignored

examples/react/apollo-client-defer/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

dotansimha/graphql-yoga

45 of 47 projects failed to build with the old tsc and were ignored

website/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

facebook/docusaurus

25 of 40 projects failed to build with the old tsc and were ignored

examples/classic-typescript/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

feathersjs/feathers

19 of 27 projects failed to build with the old tsc and were ignored

packages/generators/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

getsentry/sentry-javascript

165 of 189 projects failed to build with the old tsc and were ignored

dev-packages/e2e-tests/test-applications/nextjs-15/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

graphql-kit/graphql-voyager

2 of 4 projects failed to build with the old tsc and were ignored

tsconfig.lib.json

tsconfig.json

@typescript-bot
Copy link
Collaborator Author

heyxyz/hey

3 of 14 projects failed to build with the old tsc and were ignored

packages/ui/tsconfig.json

apps/web/tsconfig.json

apps/og/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

@typescript-bot
Copy link
Collaborator Author

ikatyang/emoji-cheat-sheet

tsconfig.json

  • error TS1544: Named imports from a JSON file into an ECMAScript module are not allowed when 'module' is set to 'Node16'.
  • error TS1543: Importing a JSON file into an ECMAScript module requires a 'type: "json"' import attribute when 'module' is set to 'Node16'.

@typescript-bot
Copy link
Collaborator Author

immich-app/immich

2 of 7 projects failed to build with the old tsc and were ignored

server/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

immutable-js/immutable-js

1 of 4 projects failed to build with the old tsc and were ignored

website/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

ionic-team/stencil

38 of 42 projects failed to build with the old tsc and were ignored

tsconfig.json

@typescript-bot
Copy link
Collaborator Author

ItzCrazyKns/Perplexica

ui/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

spacedriveapp/spacedrive

4 of 7 projects failed to build with the old tsc and were ignored

scripts/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

streetwriters/notesnook

11 of 19 projects failed to build with the old tsc and were ignored

packages/streamable-fs/tsconfig.json

apps/desktop/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

t3-oss/create-t3-app

www/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

th-ch/youtube-music

tsconfig.json

@typescript-bot
Copy link
Collaborator Author

trpc/trpc

29 of 36 projects failed to build with the old tsc and were ignored

www/og-image/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

ueberdosis/tiptap

tsconfig.json

tests/cypress/tsconfig.json

packages/pm/tsconfig.json

packages/extension-character-count/tsconfig.json

demos/tsconfig.vue-3.json

demos/tsconfig.vue-2.json

demos/tsconfig.react.json

demos/tsconfig.base.json

@typescript-bot
Copy link
Collaborator Author

Uniswap/web3-react

5 of 14 projects failed to build with the old tsc and were ignored

example/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

upscayl/upscayl

renderer/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

urql-graphql/urql

1 of 21 projects failed to build with the old tsc and were ignored

tsconfig.json

packages/vue-urql/tsconfig.json

packages/svelte-urql/tsconfig.json

packages/storage-rn/tsconfig.json

packages/solid-urql/tsconfig.json

packages/react-urql/tsconfig.json

packages/preact-urql/tsconfig.json

packages/next-urql/tsconfig.json

packages/core/tsconfig.json

exchanges/throw-on-error/tsconfig.json

exchanges/retry/tsconfig.json

exchanges/request-policy/tsconfig.json

exchanges/refocus/tsconfig.json

exchanges/populate/tsconfig.json

exchanges/persisted/tsconfig.json

exchanges/graphcache/tsconfig.json

exchanges/execute/tsconfig.json

exchanges/context/tsconfig.json

exchanges/auth/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

vercel/nextjs-subscription-payments

tsconfig.json

@typescript-bot
Copy link
Collaborator Author

vercel/platforms

tsconfig.json

@typescript-bot
Copy link
Collaborator Author

wandb/openui

frontend/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

windingwind/zotero-pdf-translate

tsconfig.json

@RyanCavanaugh RyanCavanaugh added the Needs Investigation This issue needs a team member to investigate its status. label Sep 30, 2024
@RyanCavanaugh
Copy link
Member

@iisaduan please take a look at e.g. #60095 (comment), I think something happened with your fragment change

@robertIsaac
Copy link

hi @iisaduan
I'm facing the error TS2604 mentioned above and it seems typescript 5.7 was released without fixing it

@iisaduan
Copy link
Member

@robertIsaac The errors should be fixed by 5.7.3. Can you double check what version you are using?

@robertIsaac
Copy link

yes it's 5.7.3 (Same with 5.8)
you can try it out at https://github.com/SAP/fundamental-ngx/tree/chore/ts-error (note the branch name)
and just run nx b nx-plugin to see the error
downgrading to 5.6 solve the problem or changing jsxFragmentFactory from Fragment to null

@iisaduan
Copy link
Member

I'm taking a look!

@iisaduan
Copy link
Member

@robertIsaac apologies for the delay in response! The behavior change is intentional, as the 5.7 change was to make fragments type check in the same way, both when written as <></> or when <Fragment></Fragement>, where Fragment is the function that jsxFragementFactory option resolves to. The current behavior is correct because changing the erroring fragments to <Fragment></Fragement> will not pass the check in versions <5.7. Here is a link to original issue.

The definitions in typedoc were relying on that bug, and I'll file an issue with them and cc you. For now, the best temp fix is probably to leave jsxFragmentFactory: null.

@robertIsaac
Copy link

Thank you for your time and the explanation

@iisaduan
Copy link
Member

@robertIsaac actually, it seems typedoc has fixed the issue as of typedoc 0.27.0. Are you able to update?

@robertIsaac
Copy link

I will check it tomorrow

@robertIsaac
Copy link

@iisaduan while there are a lot of breaking changes in 0.26 and 0.27 and I don't have the time now to investigate and fix the breaking changes, I could confirm that updating to 0.27 fixed the problems with the fragment
so for now we will continue jsxFragmentFactory: null till we someone could update to 0.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Investigation This issue needs a team member to investigate its status.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants