Skip to content

[isolatedDecalaration] Quick fix for isolatedDeclarations drops trailing unknown in generics instantiation #61208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blickly opened this issue Feb 17, 2025 · 0 comments Β· Fixed by #61227

Comments

@blickly
Copy link
Contributor

blickly commented Feb 17, 2025

πŸ”Ž Search Terms

isolatedDeclaerations autofix, drop, missing, unknown, type parameter, type argument, generics, template type

πŸ•— Version & Regression Information

  • This changed between versions 5.6 and 5.7

⏯ Playground Link

https://www.typescriptlang.org/dev/bug-workbench/?isolatedDeclarations=true&ts=5.7.3#code/PTAEAEEsGcHsBsCGAXApgEwCKoMZIE4qSwB20AXKMvgK6oBQIEi88sA7gFIWgBmL0Bk3DpcBIqUrU69RmHC9I8VCUQBbVFNTRkAOmTR6y5KAAeoSjRIBrEhxIBuWalMAHWPhM5SO0NFAAvKAkqOygAMqoyAAUANqmALoAlA5AA

πŸ’» Code

let x : unknown;
export const s = new Set([x]);

πŸ™ Actual behavior

Applying the quick fix gives incorrect code with unknown missing:

let x : unknown;
export const s: Set = new Set([x]);

πŸ™‚ Expected behavior

let x : unknown;
export const s: Set<unknown> = new Set([x]);

Additional information about the issue

I haven't checked yet, but I'd guess this to be related to #59665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant