-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Nuget Packages - TSC 1.8 is not preferred to Typescript tooling (TSC 1.7.6) #6715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Currently the |
@mhegazy - Thanks for the feedback. However, having tried your suggestion to change the Is there an example project available that shows the Nuget TSC compiler + MSBuild combination working? |
@snerks It should be |
Thanks @paulvanbrenk. I tried this:
Same compiler error. |
Can you share the detailed build diagnostics? And you project file? |
How do I collect detailed build diagnostics? |
For info, I'm seeing this after a build attempt: Warning 0 Your project file uses a newer version of the TypeScript compiler and tools than supported by this version of Visual Studio. Your project may be using TypeScript language features that will result in errors when compiling with this version of the TypeScript tools. To remove this warning, remove the element from your project file. |
What is the preferred way to deliver detailed build diagnostics (2555 lines)? |
You're importing the typescript targets and props file twice, remove the once, which don't point to the NuGet package folder. |
I removed MSBuild references not pointing to the Nuget package folder. The detailed Build output now reports success: 1>Build succeeded. Should I expect to see squigglys in the IDE and the original compiler error in the Error List? Screenshot: |
The version of your VS installation (1.7.6) is a different one from the one you are using to build in NuGet (1.8.0), so the error is expected. you can upgrade your VS installation, or use the older NuGet package to build. |
@mhegazy @paulvanbrenk |
Added logic to help determine when the version of the Nuget package doesn't match the version of the language service in VS, and show a warning in VS. |
In a VS2015 Typescript HTML App, if I reference the Nuget packages for the 1.8 Typescript compiler and MSBuild Tasks, does the 1.8 TSC compiler in the Nuget package get used in preference to the version associated with the VS2015 Typescript tooling (1.7.6)?
I'm seeing that an attempt to reference a Stateless Functional Component (as shown in the SimpleGreeter example in the release notes) in (say) an App.tsx file, I still get the TSC 1.7 compiler "error":
Error TS2605 JSX element type 'Element' is not a constructor function for JSX elements.
Property 'render' is missing in type 'Element'.
The text was updated successfully, but these errors were encountered: