Skip to content

Parameters in verifyNavigationBarContains are being ignored #8766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue May 23, 2016 · 1 comment
Closed

Parameters in verifyNavigationBarContains are being ignored #8766

ghost opened this issue May 23, 2016 · 1 comment
Labels
Infrastructure Issue relates to TypeScript team infrastructure

Comments

@ghost
Copy link

ghost commented May 23, 2016

In src/harness/fourslash.ts, verifyNavigationBarContains doesn't use its parameters isAdditionalSpan and markerPosition. We should find a use for them or remove them.
@ghost ghost self-assigned this May 23, 2016
@mhegazy mhegazy added the Infrastructure Issue relates to TypeScript team infrastructure label May 23, 2016
@ghost
Copy link
Author

ghost commented May 27, 2016

This is irrelevant now that #8812 changed the format of navbar tests.

@ghost ghost closed this as completed May 27, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhegazy