Always include a root node in the navigation bar. #8812
Conversation
|
Hi @Andy-MS, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
ghost
mentioned this pull request
|
👍 |
This lets us change the navigation bar counting algorithm to traverse from the root only, so it never has duplicate nodes.
This reduces the confusion of verify.navigationBarCount() counting duplicate items.
ghost
|
Added a new commit which needs review. |
ghost
mentioned this pull request
node 6.2.0: "a".localeCompare("A") is -1.
node 0.10.45: "a".localeCompare("A") is 32.
|
|
||
| // Remove any properties that tend to all have the same value so that test data is easier to read. | ||
| private simplifyNavigationBar(items: ts.NavigationBarItem[]): any { | ||
| return items.map(item => { |
There was a problem hiding this comment.
if this is only for comparison purposes, i would do this in the replacer function for JSON.stringify(items, (k,v)=> { if (key === "indent") return undefined; return v; });
|
test changes look good. i would give the JSON.stringify(item, replacerFunction) a try. |
This should wait for #8764 to be resolved so that the root has all the children it needs.