Skip to content

Missing children in navigation bar #8764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue May 23, 2016 · 1 comment
Closed

Missing children in navigation bar #8764

ghost opened this issue May 23, 2016 · 1 comment
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Milestone
TypeScript 2.0

Comments

@ghost
Copy link

ghost commented May 23, 2016

#8762 unearthed some issues with navigation bar items. We should be creating childItems for more node types.

  • Modules
    • navbar_contains-no-duplicates: Foundation
    • navigationBarItemsModules: B and C
  • Interfaces
    • navigationBarItemsInsideMethodsAndConstructors: LocalInterfaceInConstructor and LocalInterfaceInMethod
  • Enums
    • navigationBarItemsInsideMethodsAndConstructors: LocalEnumInMethod
    • navigationBarItemsItems: Values
    • navbar01: Values
  • Classes
    • navigationBarItemsItems: Point
    • navbar01: Point
@ghost ghost self-assigned this May 23, 2016
@mhegazy mhegazy added the Bug A bug in TypeScript label May 23, 2016
@mhegazy mhegazy added this to the TypeScript 2.0 milestone May 23, 2016
This was referenced May 24, 2016
Merged
Merged
Merged
Merged
Merged
@ghost
Copy link
Author

ghost commented May 25, 2016

This should be resolved by #8780, #8811, #8813, and #8814. Note that whenever one is merged the others will need to be updated to get their verify.navigationBarCount calls right. Then we can merge #8812 to make that simpler in the future.

@ghost ghost closed this as completed May 26, 2016
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label May 26, 2016
@ghost ghost mentioned this issue May 26, 2016
Merged
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 2.0
Development

No branches or pull requests
1 participant
@mhegazy