Include classes as childItems in navigation bar #8811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Andy-MS, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
This was referenced May 25, 2016
| @@ -11,4 +11,4 @@ | |||
| //// } | |||
| ////} | |||
|
|
|||
| verify.navigationBarCount(6); // 2x(class + field + constructor) | |||
| verify.navigationBarCount(9); // global + 2 children + 2x(class + field + constructor) | |||
There was a problem hiding this comment.
this is getting silly. we should change navigationBarCount to take a level, or indent, and count all entries at that level.
|
👍 |
|
feel free to update the tests in a different PR. |
ghost
force-pushed
the
navbar_class_child_item
branch
from
c38772f to
1bae2c4
Compare
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #8764