When augmenting Array.prototype, make the functions non-enumerable by de... #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default so as to not affect clients that call for-in
| @@ -25,22 +25,44 @@ module TypeScript.Syntax { | |||
| // Debug.assert(!separators || separators.length === 0); | |||
| } | |||
|
|
|||
| Array.prototype.kind = function () { | |||
| return this.separators === undefined ? SyntaxKind.List : SyntaxKind.SeparatedList; | |||
| function addArrayFunction(name: string, func: Function) { | |||
There was a problem hiding this comment.
Maybe just make this a defineProperty utility function.
|
👍 |
|
Would actaully prefer to not make this functionality general. We don't really want to be mucking with properties most of the time. |
CyrusNajmabadi
added a commit
that referenced
this pull request
Nov 1, 2014
When augmenting Array.prototype, make the functions non-enumerable by de...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...fault so as to not affect clients that call for-in