Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
It's probably more conversation starter then actual PR. If you find it useful/appropriate I'll add tests.
The problem:
Imagine that we have such
tsconfig.json
:And
tsconfig.base.json
is:As a result of extending base config we will get compilerOptions which looks like that:
As you can see, "lib" now only contains items from
tsconfig.json
. It means we can't add extra items to libs, we can only completely redeclare them. And i'm not sure if it was intended or not.The only bad thing with merging "lib" i can think of is it becomes impossible to redeclare them. But probably it's not an issue.
What do you think?