Port rules provider fix to release-2.3 #16051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jramsay
changed the title
minestarks
approved these changes
May 23, 2017
mhegazy
approved these changes
May 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all rules to the RulesProvider’s RulesMap regardless of user options
Pass FormatCodeSettings to the FormattingContext
Update RuleOperationContext's InContext to check if a rule should be applied based on the FormattingCodeOptions
Update rules to consume new RuleOperationContext options check
compareDataObjects fix to check if the object has the same number of keys
Fixes:
• TS: [TSServer] Formatting RulesProvider (re)initialization performance issues
• VS: Bug 373219: [TypeScript Perf] WebForms_DDRIT.0300.Typing HTML5 HTML regressed Duration_AccumulatedElapsedTime (60ms)