Report errors for usage of private types when generating declaration file #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbols when writing types in declaration file
…vate type/module Fixes #86
| } | ||
| private static myPrivateStaticMethod<T extends privateClass>() { | ||
| ~~~~~~~~~~~~~~~~~~~~~~ | ||
| !!! TypeParameter 'T' of public static method from exported class has or is using private name 'privateClass'. |
There was a problem hiding this comment.
Error message is wrong here -- the method is not public. Related: logged #163
There was a problem hiding this comment.
fixed this. thanks for finding this
…ype parameter constraint of private methods Also incorporates code review feedback
| @@ -645,7 +645,7 @@ module ts { | |||
| } | |||
|
|
|||
| // If symbol is directly available by its name in the symbol table | |||
| if (isAccessible(symbols[symbol.name])) { | |||
| if (hasProperty(symbols, symbol.name) && isAccessible(symbols[symbol.name])) { | |||
There was a problem hiding this comment.
I have added a lookup method for Map, it would be more consistent.
There was a problem hiding this comment.
i will update that when I resolve merge conflicts.
|
👍 |
sheetalkamat
added a commit
that referenced
this pull request
Aug 6, 2014
Report errors for usage of private types when generating declaration file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this change reports errors only for heritage clause and constraints of type parameters if the name is not public