Skip to content

[Master] fix16017 Remove redeclare of promise from lib.es2016.iterable.d.ts #16573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

yuit
Copy link
Contributor

@yuit yuit commented Jun 15, 2017

Fix #16017

* @param values An array of Promises.
* @returns A new Promise.
*/
all<TAll>(values: Iterable<TAll | PromiseLike<TAll>>): Promise<TAll[]>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By removing this, you can no longer take an Iterable for Promise.all or Promise.race. Consider:

function* g() {
  yield Promise.resolve(1);
  yield Promise.resolve(2);
}
Promise.all(g()).then(results => {
});

We either need to structure the files in such a way as to prevent this, or customize the ordering of lib files when we bind to enforce the correct order.

@yuit yuit closed this Jun 22, 2017
@yuit yuit deleted the master-fix16017 branch June 22, 2017 18:53
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants