When adding completions for a module, don't get the type of the module if not necessary. #16768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e if not necessary.
ghost
ghost
mentioned this pull request
| if (isValidAccess(symbol)) { | ||
| symbols.push(symbol); | ||
| // If the module is merged with a value, we must get the type of the class and add its propertes (for inherited static methods). | ||
| if (!isTypeLocation && symbol.declarations.some(d => d.kind !== SyntaxKind.SourceFile && d.kind !== SyntaxKind.ModuleDeclaration && d.kind !== SyntaxKind.EnumDeclaration)) { |
There was a problem hiding this comment.
It isn't possible to merge enum with anything else right so adding ! might be useful to not enumerate through the declarations?
There was a problem hiding this comment.
It's possible to merge enums and namespaces. But we could handle enums separately, and assert that getExportsOfModule is only called for modules.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would first add completions for all the exports, then convert the module to a type and add completions for all of its properties -- but those are just the exports.
Also,
HasExportsincludes classes, but we don't need to handle classes in that block (since they are handled byaddTypePropertiesjust fine).