Fix partial type relations #17382
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| //// [mappedTypePartialConstraints.ts] | ||
| // Repro from #16985 | ||
|
|
||
| interface MyInterface { | ||
| something: number; | ||
| } | ||
|
|
||
| class MyClass<T extends MyInterface> { | ||
| doIt(data : Partial<T>) {} | ||
| } | ||
|
|
||
| class MySubClass extends MyClass<MyInterface> {} | ||
|
|
||
| function fn(arg: typeof MyClass) {}; | ||
|
|
||
| fn(MySubClass); | ||
|
|
||
|
|
||
| //// [mappedTypePartialConstraints.js] | ||
| // Repro from #16985 | ||
| var __extends = (this && this.__extends) || (function () { | ||
| var extendStatics = Object.setPrototypeOf || | ||
| ({ __proto__: [] } instanceof Array && function (d, b) { d.__proto__ = b; }) || | ||
| function (d, b) { for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p]; }; | ||
| return function (d, b) { | ||
| extendStatics(d, b); | ||
| function __() { this.constructor = d; } | ||
| d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __()); | ||
| }; | ||
| })(); | ||
| var MyClass = (function () { | ||
| function MyClass() { | ||
| } | ||
| MyClass.prototype.doIt = function (data) { }; | ||
| return MyClass; | ||
| }()); | ||
| var MySubClass = (function (_super) { | ||
| __extends(MySubClass, _super); | ||
| function MySubClass() { | ||
| return _super !== null && _super.apply(this, arguments) || this; | ||
| } | ||
| return MySubClass; | ||
| }(MyClass)); | ||
| function fn(arg) { } | ||
| ; | ||
| fn(MySubClass); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| === tests/cases/compiler/mappedTypePartialConstraints.ts === | ||
| // Repro from #16985 | ||
|
|
||
| interface MyInterface { | ||
| >MyInterface : Symbol(MyInterface, Decl(mappedTypePartialConstraints.ts, 0, 0)) | ||
|
|
||
| something: number; | ||
| >something : Symbol(MyInterface.something, Decl(mappedTypePartialConstraints.ts, 2, 23)) | ||
| } | ||
|
|
||
| class MyClass<T extends MyInterface> { | ||
| >MyClass : Symbol(MyClass, Decl(mappedTypePartialConstraints.ts, 4, 1)) | ||
| >T : Symbol(T, Decl(mappedTypePartialConstraints.ts, 6, 14)) | ||
| >MyInterface : Symbol(MyInterface, Decl(mappedTypePartialConstraints.ts, 0, 0)) | ||
|
|
||
| doIt(data : Partial<T>) {} | ||
| >doIt : Symbol(MyClass.doIt, Decl(mappedTypePartialConstraints.ts, 6, 38)) | ||
| >data : Symbol(data, Decl(mappedTypePartialConstraints.ts, 7, 7)) | ||
| >Partial : Symbol(Partial, Decl(lib.d.ts, --, --)) | ||
| >T : Symbol(T, Decl(mappedTypePartialConstraints.ts, 6, 14)) | ||
| } | ||
|
|
||
| class MySubClass extends MyClass<MyInterface> {} | ||
| >MySubClass : Symbol(MySubClass, Decl(mappedTypePartialConstraints.ts, 8, 1)) | ||
| >MyClass : Symbol(MyClass, Decl(mappedTypePartialConstraints.ts, 4, 1)) | ||
| >MyInterface : Symbol(MyInterface, Decl(mappedTypePartialConstraints.ts, 0, 0)) | ||
|
|
||
| function fn(arg: typeof MyClass) {}; | ||
| >fn : Symbol(fn, Decl(mappedTypePartialConstraints.ts, 10, 48)) | ||
| >arg : Symbol(arg, Decl(mappedTypePartialConstraints.ts, 12, 12)) | ||
| >MyClass : Symbol(MyClass, Decl(mappedTypePartialConstraints.ts, 4, 1)) | ||
|
|
||
| fn(MySubClass); | ||
| >fn : Symbol(fn, Decl(mappedTypePartialConstraints.ts, 10, 48)) | ||
| >MySubClass : Symbol(MySubClass, Decl(mappedTypePartialConstraints.ts, 8, 1)) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| === tests/cases/compiler/mappedTypePartialConstraints.ts === | ||
| // Repro from #16985 | ||
|
|
||
| interface MyInterface { | ||
| >MyInterface : MyInterface | ||
|
|
||
| something: number; | ||
| >something : number | ||
| } | ||
|
|
||
| class MyClass<T extends MyInterface> { | ||
| >MyClass : MyClass<T> | ||
| >T : T | ||
| >MyInterface : MyInterface | ||
|
|
||
| doIt(data : Partial<T>) {} | ||
| >doIt : (data: Partial<T>) => void | ||
| >data : Partial<T> | ||
| >Partial : Partial<T> | ||
| >T : T | ||
| } | ||
|
|
||
| class MySubClass extends MyClass<MyInterface> {} | ||
| >MySubClass : MySubClass | ||
| >MyClass : MyClass<MyInterface> | ||
| >MyInterface : MyInterface | ||
|
|
||
| function fn(arg: typeof MyClass) {}; | ||
| >fn : (arg: typeof MyClass) => void | ||
| >arg : typeof MyClass | ||
| >MyClass : typeof MyClass | ||
|
|
||
| fn(MySubClass); | ||
| >fn(MySubClass) : void | ||
| >fn : (arg: typeof MyClass) => void | ||
| >MySubClass : typeof MySubClass | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // Repro from #16985 | ||
|
|
||
| interface MyInterface { | ||
| something: number; | ||
| } | ||
|
|
||
| class MyClass<T extends MyInterface> { | ||
| doIt(data : Partial<T>) {} | ||
| } | ||
|
|
||
| class MySubClass extends MyClass<MyInterface> {} | ||
|
|
||
| function fn(arg: typeof MyClass) {}; | ||
|
|
||
| fn(MySubClass); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an awfully specific check - does it work on homomorphic mapped types in which all properties of the type being mapped are already optional? For example:
The same question applies to if you used
Readonly<T>or others.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you're getting at. The only way we can be certain that all properties of the type that results from a mapping operation are optional is if the mapped type includes a
?in the template specification. That's what we're checking here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed offline, that example doesn't apply because a constraint being all-optional (e.g.
MyInterface) doesn't guarantee thatTitself will be all-optional.