Fix formatting of multiline variable declaration initializers #19570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19167
Sets the
effectiveParentStartLine
to the last line of a multiline variable declaration name, so thateffectiveParentStartLine === startLine
evaluates totrue
.This fixes the case presented in the issue, and also for array destructuring. It does not handle the case of a type definition after the variable name:
Or a type definition followed by an initializer:
Which will behave the same as prior to the fix. These can be fixed by offsetting
effectiveParentStartLine
to be the last line of the previous relevantNode
, which I can do if the general idea is sound.