Skip to content

Simplify documentHighlights #20091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Nov 17, 2017
Merged

Simplify documentHighlights #20091

1 commit merged into from
Nov 17, 2017

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2017

There were a lot of unnecessary undefined checks -- node is always defined, and we even Debug.assert(node.parent !== undefined); at the very beginning.

@ghost ghost force-pushed the documentHighlights branch from 05b8054 to 66ae9f7 Compare November 17, 2017 03:26
@ghost ghost requested a review from armanio123 November 17, 2017 03:26
@ghost ghost force-pushed the documentHighlights branch from 66ae9f7 to e13012b Compare November 17, 2017 15:19
@ghost ghost force-pushed the documentHighlights branch from e13012b to 890bb2c Compare November 17, 2017 15:19
@ghost ghost merged commit 0c0f4b8 into master Nov 17, 2017
@ghost ghost deleted the documentHighlights branch November 17, 2017 18:19
errendir added a commit to errendir/TypeScript that referenced this pull request Nov 20, 2017
* origin/master: (140 commits)
  test overriding Session.event
  Update editorServices.ts
  Fix semantic merge conflict (microsoft#20119)
  LEGO: check in for master to temporary branch.
  Moved minified file exclusion
  Fixed internal safelist
  For import completion, if multiple re-exports exist, choose the one with the shortest path (microsoft#20049)
  Bundle fileName with CodeActionCommand (microsoft#19881)
  Simplify documentHighlights (microsoft#20091)
  LEGO: check in for master to temporary branch.
  Support semantic classification of alias (microsoft#20012)
  In `getContextualTypeForBinaryOperand`, only need to look for `=` assignment operator, not e.g. `+=` (microsoft#20037)
  lineAction: Use an enum instead of true | false | undefined (microsoft#20086)
  LEGO: check in for master to temporary branch.
  cleanup NodeTypingsInstaller
  remove comments
  type `event` callback correctly
  update baselines
  defer callback and remove handler object
  Support arbitrary prototype property assignments in navigation bar (microsoft#19923)
  ...
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant