Skip to content

Moved minified file exclusion #20109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2017
Merged

Conversation

billti
Copy link
Member

@billti billti commented Nov 17, 2017

CC @RyanCavanaugh

This excludes minified files only after all other safelist processing. It also excludes the _references.js file with may already exist in old projects and continue to suck in all JavaScript.

Also included the improved Kendo detection from @armanio123

@@ -19,8 +19,8 @@
"exclude": [["^", 1, "/.*"]],
"types": ["office"]
},
"Minified files": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make this change in editorServices.ts#158

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@billti billti merged commit 3d5712d into release-2.5 Nov 17, 2017
Copy link
Member

@RyanCavanaugh RyanCavanaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

billti added a commit that referenced this pull request Nov 17, 2017
billti added a commit that referenced this pull request Nov 18, 2017
@mhegazy mhegazy deleted the dev/billti/fixMinifiedLibraries branch November 20, 2017 20:35
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants