Correct project root path passed to Typings Installer #20181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createInstallTypingsRequest
has its own logic for extracting theproject root path from the project name and it disagrees with the
versions in the project flavors. In particular, it only drops the last
component of the name if it exists. For folder projects and JS-only
contexts, this will not be the case, but the last entry should still be
dropped.
TL;DR: stop creating filewatchers for
"c:/foo/foo.csproj*jscontent/node_modules"