Update project on PackageInstalledResponse #20211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As with `SetTypings`, new typings have been installed so the project should be updated and the client should be notified (via event). Changed PackageInstalledResponse from "event" to "action" for the sake of explicitness. Fixes microsoft#20084.
|
Pulled out #20212 for the first commit, since it's more urgent. |
mhegazy
approved these changes
Nov 22, 2017
|
Do we need to port this to release-2.6? |
weswigham
approved these changes
Nov 22, 2017
|
Shouldn't we be watching |
|
@Andy-MS I believe the server watches that folder but the client does not. The event is for the client. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with
SetTypings, new typings have been installed so the project should be updated and the client should be notified (via event).Changed PackageInstalledResponse from "event" to "action" for the sake of explicitness.
Fixes #20084.