Accept Public API changes that are causing test failures #21214
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuckton
commented
Jan 16, 2018
| @@ -1800,7 +1800,6 @@ declare namespace ts { | |||
| NoTruncation = 1, | |||
| WriteArrayAsGenericType = 2, | |||
| WriteDefaultSymbolWithoutName = 4, | |||
| UseStructuralFallback = 8, | |||
There was a problem hiding this comment.
@weswigham, this was changed in #21203. Is this intended to be part of the public API?
| @@ -1827,7 +1826,6 @@ declare namespace ts { | |||
| NoTruncation = 1, | |||
| WriteArrayAsGenericType = 2, | |||
| WriteDefaultSymbolWithoutName = 4, | |||
| UseStructuralFallback = 8, | |||
There was a problem hiding this comment.
@weswigham, this was changed in #21203. Is this intended to be part of the public API?
| function forEachLeadingCommentRange<T, U>(text: string, pos: number, cb: (pos: number, end: number, kind: CommentKind, hasTrailingNewLine: boolean, state: T) => U, state: T): U | undefined; | ||
| function forEachTrailingCommentRange<U>(text: string, pos: number, cb: (pos: number, end: number, kind: CommentKind, hasTrailingNewLine: boolean) => U): U | undefined; | ||
| function forEachTrailingCommentRange<T, U>(text: string, pos: number, cb: (pos: number, end: number, kind: CommentKind, hasTrailingNewLine: boolean, state: T) => U, state: T): U | undefined; | ||
| function forEachLeadingCommentRange<T, U>(text: string, pos: number, cb: (pos: number, end: number, kind: CommentKind, hasTrailingNewLine: boolean, state: T) => U, state?: T): U | undefined; |
| NakedTypeVariable = 1, | ||
| MappedType = 2, | ||
| ReturnType = 4, | ||
| Contravariant = 1, |
There was a problem hiding this comment.
@ahejlsberg this changed in #21157. Are these changes intended to be part of the public API?
|
Please ignore. It looks like there may have been an issue building locally with gulp that was causing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several recent PRs (#21190, #21157, #21203) have pushed changes that resulted in public API changes, however the public API was not updated in the tests.