Skip to content

Make getCombinedCodeFix API public #21234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Jan 17, 2018
Merged

Make getCombinedCodeFix API public #21234

1 commit merged into from
Jan 17, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 17, 2018

Fixes #20538 and #14549

@ghost ghost requested a review from amcasey January 17, 2018 19:32
amcasey
amcasey reviewed Jan 17, 2018
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typing fixId as {}, rather than string (which I still think is sensible), is causing some minor inconvenience on the VS side. Give me a few more minutes to confirm that I've got it sorted out before we merge.

amcasey
amcasey approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it sorted out.

@ghost ghost merged commit f96dc84 into master Jan 17, 2018
@ghost ghost deleted the combinedcodefix branch January 17, 2018 20:42
@ghost ghost mentioned this pull request Jan 17, 2018
Closed
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amcasey