Handle variable declaration without initializer in Convert to ES6 Module #21835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Feb 9, 2018
|
Did you mean fixes #21810? |
|
Never mind, I see that's a separate issue. Though in the same part of the code. |
|
Looks like it could be a dup though? |
|
Have a separate fix for that at #21843. Will rebase that once this is in. Or you could integrate it into this. |
|
@mhegazy Shall I port this to 2.7? The hit-count is quite high. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21786
@Andy-MS I just guessed, so feel free to suggest a better solution.