Skip to content

Add DOMTokenList.replace() #22475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add DOMTokenList.replace() #22475

wants to merge 1 commit into from

Conversation

lenovouser
Copy link

Fixes #22466

@Jessidhia
Copy link

Unfortunately this is the wrong repo.

lib.dom.d.ts is actually compiled from merging a bunch of .json files in https://github.com/Microsoft/TSJS-lib-generator so you need to PR that instead

@lenovouser lenovouser mentioned this pull request Mar 13, 2018
Merged
@lenovouser
Copy link
Author

lenovouser commented Mar 13, 2018 •
edited
Loading

@Kovensky are you sure? It seems like there are two files,

src/lib/dom.generated.d.ts

which looks like the one you are talking about and this one here

lib/lib.dom.d.ts

which seems to be a different one.

Nevertheless I still submitted a patch to microsoft/ts-lib-generator 👍

@mhegazy
Copy link
Contributor

mhegazy commented Mar 29, 2018

Fixed by microsoft/TypeScript-DOM-lib-generator#391

@mhegazy mhegazy closed this Mar 29, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
@lenovouser lenovouser deleted the domtokenlist-replace branch August 8, 2018 12:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lenovouser @Jessidhia @mhegazy