Skip parens and non-null assertions when looking for this-context #23097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
reviewed
Apr 2, 2018
src/compiler/utilities.ts
Outdated
| return node; | ||
| } | ||
|
|
||
| export function skipParenthesesAndNonNull(node: Expression): Expression; |
There was a problem hiding this comment.
Should probably just use skipOuterExpressions, which is all this and more.
mhegazy
approved these changes
Apr 2, 2018
weswigham
approved these changes
Apr 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check is syntactic and was previously very simple.
Fixes #23040