Fix RWC tsconfig and lib paths #23979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
May 8, 2018
rbuckton
suggested changes
May 8, 2018
src/harness/utils.ts
Outdated
| @@ -86,4 +86,8 @@ namespace utils { | |||
| export function addUTF8ByteOrderMark(text: string) { | |||
| return getByteOrderMarkLength(text) === 0 ? "\u00EF\u00BB\u00BF" + text : text; | |||
| } | |||
|
|
|||
| export function isTsConfigFile(file: { path: string }): boolean { | |||
There was a problem hiding this comment.
This should probably be in vpath.ts with the other is path methods.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vfs's
readProjecthad a different special casing logic thanrwc, this aligns them. It was also neglecting to actually place tsconfigs into the vfs - now it does. This should fix the last of our harness-related RWC failures. The fixed libs also revealed #23977.