Add suggestion diagnostics for unused label and unreachable code #24261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: Come up with new descriptions for the |
ghost
force-pushed
the
bindSuggestionDiagnostics
branch
from
536123f to
ad620b8
Compare
mhegazy
reviewed
May 21, 2018
| @@ -33,9 +33,7 @@ tests/cases/conformance/jsx/16.tsx(1,2): error TS17008: JSX element 'a' has no c | |||
| tests/cases/conformance/jsx/16.tsx(1,10): error TS1005: '</' expected. | |||
| tests/cases/conformance/jsx/17.tsx(1,2): error TS17008: JSX element 'a' has no corresponding closing tag. | |||
| tests/cases/conformance/jsx/17.tsx(1,10): error TS1005: '</' expected. | |||
| tests/cases/conformance/jsx/18.tsx(1,9): error TS2695: Left side of comma operator is unused and has no side effects. | |||
There was a problem hiding this comment.
this was actually a good error usually... caught some obvious bugs.. do not know about disabling it by default..
ghost
force-pushed
the
bindSuggestionDiagnostics
branch
from
be5783d to
bb4e4d6
Compare
sheetalkamat
approved these changes
May 21, 2018
mhegazy
approved these changes
May 21, 2018
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24026
This means that unreachable-code and unused-label diagnostics will no longer show up in the command line by default (though they will with
--allowUnreachableCode false --allowUnusedLabel false), but they will show up in the editor as suggestions. Note if--allowUnreachableCode trueis set, there will not even be a suggestion.