Support spreading and destructuring of iterators in ES6#2498
Merged
JsonFreeman merged 20 commits intomasterfrom Apr 8, 2015
Merged
Support spreading and destructuring of iterators in ES6#2498JsonFreeman merged 20 commits intomasterfrom
JsonFreeman merged 20 commits intomasterfrom
Conversation
src/compiler/checker.ts
Outdated
Contributor
There was a problem hiding this comment.
That's an odd requirement given that the grammar only says this:
RestParameter:
... Identifier TypeAnnotation_opt
I don't see why, at grammar check time, we'd care if the parameter was an array type or not.
Contributor
Author
There was a problem hiding this comment.
It's the type system, not the grammar checker. I will fix the comment
Contributor
Author
|
To see a design proposal, see #1900 (comment) |
Contributor
|
forgot to approve 👍 |
JsonFreeman
added a commit
that referenced
this pull request
Apr 8, 2015
Support spreading and destructuring of iterators in ES6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for a few things:
I will also add that tuples are relatively unaffected. If you declare something to be a tuple, you can still only assign a tuple to it. And if you have an array binding pattern with no rest element, its implied type is a tuple. So the following does give you an error: