-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Conformance for spec update section 4.20 Add additional tests for typeguard for class or object property #2785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
37 changes: 37 additions & 0 deletions
37
tests/baselines/reference/typeGuardsOnClassProperty.errors.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
tests/cases/conformance/expressions/typeGuards/typeGuardsOnClassProperty.ts(14,70): error TS2339: Property 'join' does not exist on type 'string | string[]'. | ||
tests/cases/conformance/expressions/typeGuards/typeGuardsOnClassProperty.ts(26,44): error TS2339: Property 'toLowerCase' does not exist on type 'string | number'. | ||
|
||
|
||
==== tests/cases/conformance/expressions/typeGuards/typeGuardsOnClassProperty.ts (2 errors) ==== | ||
// Note that type guards affect types of variables and parameters only and | ||
// have no effect on members of objects such as properties. | ||
|
||
// Note that the class's property must be copied to a local variable for | ||
// the type guard to have an effect | ||
class D { | ||
data: string | string[]; | ||
getData() { | ||
var data = this.data; | ||
return typeof data === "string" ? data : data.join(" "); | ||
} | ||
|
||
getData1() { | ||
return typeof this.data === "string" ? this.data : this.data.join(" "); | ||
~~~~ | ||
!!! error TS2339: Property 'join' does not exist on type 'string | string[]'. | ||
} | ||
} | ||
|
||
var o: { | ||
prop1: number|string; | ||
prop2: boolean|string; | ||
} = { | ||
prop1: "string" , | ||
prop2: true | ||
} | ||
|
||
if (typeof o.prop1 === "string" && o.prop1.toLowerCase()) {} | ||
~~~~~~~~~~~ | ||
!!! error TS2339: Property 'toLowerCase' does not exist on type 'string | number'. | ||
var prop1 = o.prop1; | ||
if (typeof prop1 === "string" && prop1.toLocaleLowerCase()) { } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
//// [typeGuardsOnClassProperty.ts] | ||
// Note that type guards affect types of variables and parameters only and | ||
// have no effect on members of objects such as properties. | ||
|
||
// Note that the class's property must be copied to a local variable for | ||
// the type guard to have an effect | ||
class D { | ||
data: string | string[]; | ||
getData() { | ||
var data = this.data; | ||
return typeof data === "string" ? data : data.join(" "); | ||
} | ||
|
||
getData1() { | ||
return typeof this.data === "string" ? this.data : this.data.join(" "); | ||
} | ||
} | ||
|
||
var o: { | ||
prop1: number|string; | ||
prop2: boolean|string; | ||
} = { | ||
prop1: "string" , | ||
prop2: true | ||
} | ||
|
||
if (typeof o.prop1 === "string" && o.prop1.toLowerCase()) {} | ||
var prop1 = o.prop1; | ||
if (typeof prop1 === "string" && prop1.toLocaleLowerCase()) { } | ||
|
||
//// [typeGuardsOnClassProperty.js] | ||
// Note that type guards affect types of variables and parameters only and | ||
// have no effect on members of objects such as properties. | ||
// Note that the class's property must be copied to a local variable for | ||
// the type guard to have an effect | ||
var D = (function () { | ||
function D() { | ||
} | ||
D.prototype.getData = function () { | ||
var data = this.data; | ||
return typeof data === "string" ? data : data.join(" "); | ||
}; | ||
D.prototype.getData1 = function () { | ||
return typeof this.data === "string" ? this.data : this.data.join(" "); | ||
}; | ||
return D; | ||
})(); | ||
var o = { | ||
prop1: "string", | ||
prop2: true | ||
}; | ||
if (typeof o.prop1 === "string" && o.prop1.toLowerCase()) { } | ||
var prop1 = o.prop1; | ||
if (typeof prop1 === "string" && prop1.toLocaleLowerCase()) { } |
28 changes: 28 additions & 0 deletions
28
tests/cases/conformance/expressions/typeGuards/typeGuardsOnClassProperty.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// Note that type guards affect types of variables and parameters only and | ||
// have no effect on members of objects such as properties. | ||
|
||
// Note that the class's property must be copied to a local variable for | ||
// the type guard to have an effect | ||
class D { | ||
data: string | string[]; | ||
getData() { | ||
var data = this.data; | ||
return typeof data === "string" ? data : data.join(" "); | ||
} | ||
|
||
getData1() { | ||
return typeof this.data === "string" ? this.data : this.data.join(" "); | ||
} | ||
} | ||
|
||
var o: { | ||
prop1: number|string; | ||
prop2: boolean|string; | ||
} = { | ||
prop1: "string" , | ||
prop2: true | ||
} | ||
|
||
if (typeof o.prop1 === "string" && o.prop1.toLowerCase()) {} | ||
var prop1 = o.prop1; | ||
if (typeof prop1 === "string" && prop1.toLocaleLowerCase()) { } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turn this into a type alias.