Allow intersections of readonlys to be assignable to a readonly intersection #28218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahejlsberg
approved these changes
Oct 31, 2018
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
Nov 6, 2018
weswigham
added a commit
that referenced
this pull request
Nov 6, 2018
ghost
pushed a commit
that referenced
this pull request
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #12351 we've been checking
getConstraintTypeFromMappedType(target) === getIndexType(source)- the rule is in reality able to be relaxed a bit more than that. It's acceptable for thesourceto have more keys than thetarget, so long as it still provides for every key intarget(and thatSis still assignable toT's template).Fixes #27484