Make boolean compiler options in harness true only if they say 'true'#3093
Merged
JsonFreeman merged 1 commit intorelease-1.5from May 8, 2015
Merged
Make boolean compiler options in harness true only if they say 'true'#3093JsonFreeman merged 1 commit intorelease-1.5from
JsonFreeman merged 1 commit intorelease-1.5from
Conversation
Member
There was a problem hiding this comment.
You can consider just performing this once in a variable prior to the switch, and then using that variable in the appropriate locations.
Member
|
👍 |
JsonFreeman
added a commit
that referenced
this pull request
May 8, 2015
Make boolean compiler options in harness true only if they say 'true'
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, if you say
in a test, it will emit declarations! The harness just checks for the presence or absence of these options. It does not respect false.