Skip to content

Fix regression of generic T assignability to Partial<T> #32354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

andrewbranch
Copy link
Member

I think this fixes #32340.

@andrewbranch andrewbranch requested a review from weswigham July 11, 2019 17:18
@andrewbranch
Copy link
Member Author

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 11, 2019

Heya @andrewbranch, I've started to run the extended test suite on this PR at 9e34a81. You can monitor the build here. It should now contribute to this PR's status checks.

@andrewbranch
Copy link
Member Author

@weswigham yup, looks like the RWC baselines went back to normal

@andrewbranch
Copy link
Member Author

@weswigham after I merge this, do I just merge the baseline PR on mseng?

@andrewbranch
Copy link
Member Author

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 11, 2019

Heya @andrewbranch, I've started to run the parallelized Definitely Typed test suite on this PR at 9e34a81. You can monitor the build here. It should now contribute to this PR's status checks.

@andrewbranch
Copy link
Member Author

andrewbranch commented Jul 12, 2019

DT shows two instances of something like

1> No overload matches this call.
1>   Overload 1 of 2, '(props: Readonly<ProviderProps<AnyAction>>): Provider<AnyAction>', gave the following error.
1>     Property '[Symbol.observable]' is missing in type 'Store<IntlState>' but required in type 'Store<any, AnyAction>'.
1>   Overload 2 of 2, '(props: ProviderProps<AnyAction>, context?: any): Provider<AnyAction>', gave the following error.
1>     Type 'Store<IntlState>' is not assignable to type 'Store<any, AnyAction>'.

which coouuuld be related 😐

I can’t reproduce it locally, though 🤔

I don’t actually think this is related, as none of those types referenced are mapped types (thought they might be until looking at them). They’re just generic classes/interfaces. I’m running DT against master to see if the same ones show up.

@andrewbranch
Copy link
Member Author

andrewbranch commented Jul 12, 2019

Same error occurs on current master.

Now trying with 32071 reverted.

@andrewbranch
Copy link
Member Author

Yeah, #32370 indicates that the DT failures here are completely unrelated. This PR only improves things.

@andrewbranch andrewbranch merged commit 8516127 into microsoft:master Jul 12, 2019
@andrewbranch andrewbranch deleted the bug/32340 branch July 12, 2019 14:58
@sandersn
Copy link
Member

I haven't figured out what causes the two DT errors on master AND can't reproduce them locally. I'm not sure what is going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate new RWC failures
4 participants