-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Fix regression of generic T assignability to Partial<T> #32354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@typescript-bot test this |
Heya @andrewbranch, I've started to run the extended test suite on this PR at 9e34a81. You can monitor the build here. It should now contribute to this PR's status checks. |
@weswigham yup, looks like the RWC baselines went back to normal |
@weswigham after I merge this, do I just merge the baseline PR on mseng? |
@typescript-bot run dt |
Heya @andrewbranch, I've started to run the parallelized Definitely Typed test suite on this PR at 9e34a81. You can monitor the build here. It should now contribute to this PR's status checks. |
DT shows two instances of something like
which coouuuld be related 😐 I can’t reproduce it locally, though 🤔 I don’t actually think this is related, as none of those types referenced are mapped types (thought they might be until looking at them). They’re just generic classes/interfaces. I’m running DT against master to see if the same ones show up. |
Yeah, #32370 indicates that the DT failures here are completely unrelated. This PR only improves things. |
I haven't figured out what causes the two DT errors on master AND can't reproduce them locally. I'm not sure what is going on. |
I think this fixes #32340.