Support extended unicode escapes in identifiers, per es6 spec #32725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
commented
Aug 6, 2019
| @@ -1341,6 +1341,19 @@ namespace ts { | |||
| return -1; | |||
| } | |||
|
|
|||
|
|
|||
| function peekExtendedUnicodeEscape(): number { | |||
There was a problem hiding this comment.
Note that this just peeks to make sure the escape scans and doesn't validate that the resulting number is in the expected range - scanExtendedUnicodeEscape (which is called after both uses to get the real value) does all that.
rbuckton
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5291
Just to fill out the list of unicode-related things we could pretty easily fix